Open
Conversation
rablador
force-pushed
the
create-automatic-location-in-location-view-ios-1510
branch
from
b069518 to
2758ec9
Compare
rablador
changed the title
|
🚨 End to end tests failed. Please check the failed workflow run. |
rablador
force-pushed
the
create-automatic-location-in-location-view-ios-1510
branch
2 times, most recently
from
20f24e1 to
1207bc3
Compare
Collaborator
|
Would like to see transition animations implemented |
rablador
commented
Mar 24, 2026
Contributor
Author
rablador
left a comment
rablador
left a comment
There was a problem hiding this comment.
Ok!
@rablador made 1 comment.
Reviewable status: 0 of 41 files reviewed, all discussions resolved.
rablador
force-pushed
the
create-automatic-location-in-location-view-ios-1510
branch
from
1207bc3 to
cd04630
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this needs to be done
The user can select "Automatic" as entry when multihop is set to always, resulting in a new "automatic" location cell, with country and city as subtitle to indicate which location is actually connected.
How do we implement this feature?
In Always mode the user can select "Automatic" as entry. When doing so we should show an "Automatic" location cell with country and city as subtitle. If recents are turned off, the cell will be shown on top of "all locations" section.
Acceptance criteria
How should this be tested?
This change is